Nikolay Sivov : user32: Remove some dead code from unpack_dde_message() (Coverity).

Alexandre Julliard julliard at winehq.org
Fri Jul 22 15:39:35 CDT 2022


Module: wine
Branch: master
Commit: 7b77b4e3b4ea732ed592ac15f000875f5d1f1daa
URL:    https://gitlab.winehq.org/wine/wine/-/commit/7b77b4e3b4ea732ed592ac15f000875f5d1f1daa

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Fri Jul 22 21:59:10 2022 +0300

user32: Remove some dead code from unpack_dde_message() (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>

---

 dlls/user32/message.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/user32/message.c b/dlls/user32/message.c
index 71c0f339b54..65aa93d858c 100644
--- a/dlls/user32/message.c
+++ b/dlls/user32/message.c
@@ -491,7 +491,6 @@ BOOL unpack_dde_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam
             ULONGLONG hpack;
             /* hMem is being passed */
             if (size != sizeof(hpack)) return FALSE;
-            if (!size) return FALSE;
             uiLo = *lparam;
             memcpy( &hpack, buffer, size );
             hMem = unpack_ptr( hpack );
@@ -533,7 +532,6 @@ BOOL unpack_dde_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam
     case WM_DDE_EXECUTE:
 	if (size)
 	{
-	    if (!size) return FALSE;
             if (!(hMem = GlobalAlloc( GMEM_MOVEABLE|GMEM_DDESHARE, size ))) return FALSE;
             if ((ptr = GlobalLock( hMem )))
 	    {




More information about the wine-cvs mailing list