Gabriel Ivăncescu : mshtml: Implement previousElementSibling for Elements.
Alexandre Julliard
julliard at winehq.org
Wed Jul 27 16:17:08 CDT 2022
Module: wine
Branch: master
Commit: 107f318ee60b7de695d7bdc094a7bc5d38f8c3f3
URL: https://gitlab.winehq.org/wine/wine/-/commit/107f318ee60b7de695d7bdc094a7bc5d38f8c3f3
Author: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Date: Wed Jul 27 21:33:35 2022 +0300
mshtml: Implement previousElementSibling for Elements.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
dlls/mshtml/htmlelem.c | 26 ++++++++++++++++++++++++--
dlls/mshtml/tests/dom.js | 4 ++++
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c
index 5eced270c3c..76de1a0337c 100644
--- a/dlls/mshtml/htmlelem.c
+++ b/dlls/mshtml/htmlelem.c
@@ -6553,8 +6553,30 @@ static HRESULT WINAPI ElementTraversal_get_lastElementChild(IElementTraversal *i
static HRESULT WINAPI ElementTraversal_get_previousElementSibling(IElementTraversal *iface, IHTMLElement **p)
{
HTMLElement *This = impl_from_IElementTraversal(iface);
- FIXME("(%p)->(%p)\n", This, p);
- return E_NOTIMPL;
+ nsIDOMElement *nselem = NULL;
+ HTMLElement *elem;
+ HRESULT hres;
+
+ TRACE("(%p)->(%p)\n", This, p);
+
+ if(!This->dom_element) {
+ *p = NULL;
+ return S_OK;
+ }
+
+ nsIDOMElement_GetPreviousElementSibling(This->dom_element, &nselem);
+ if(!nselem) {
+ *p = NULL;
+ return S_OK;
+ }
+
+ hres = get_element(nselem, &elem);
+ nsIDOMElement_Release(nselem);
+ if(FAILED(hres))
+ return hres;
+
+ *p = &elem->IHTMLElement_iface;
+ return S_OK;
}
static HRESULT WINAPI ElementTraversal_get_nextElementSibling(IElementTraversal *iface, IHTMLElement **p)
diff --git a/dlls/mshtml/tests/dom.js b/dlls/mshtml/tests/dom.js
index e164c9502ff..93b4dc196ec 100644
--- a/dlls/mshtml/tests/dom.js
+++ b/dlls/mshtml/tests/dom.js
@@ -98,6 +98,10 @@ sync_test("ElementTraversal", function() {
"div.firstElementChild.nextElementSibling.outerHTML = " + div.firstElementChild.nextElementSibling.outerHTML);
ok(div.lastElementChild.nextElementSibling === null,
"div.lastElementChild.nextElementSibling = " + div.lastElementChild.nextElementSibling);
+ ok(div.lastElementChild.previousElementSibling.outerHTML === "<script>/* */</script>",
+ "div.lastElementChild.previousElementSibling.outerHTML = " + div.lastElementChild.previousElementSibling.outerHTML);
+ ok(div.firstElementChild.previousElementSibling === null,
+ "div.firstElementChild.previousElementSibling = " + div.firstElementChild.previousElementSibling);
div.innerHTML = "abc";
ok(div.firstElementChild === null, "div.firstElementChild = " + div.firstElementChild);
More information about the wine-cvs
mailing list