Andrew Eikum : xaudio2/tests: Remove failing legacy CLSID tests.

Alexandre Julliard julliard at winehq.org
Wed Jun 1 15:44:32 CDT 2022


Module: wine
Branch: master
Commit: c1e793f1119de0c0ef7d4bd6d9fefbafdb5dbbe5
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=c1e793f1119de0c0ef7d4bd6d9fefbafdb5dbbe5

Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Wed Jun  1 13:06:28 2022 -0500

xaudio2/tests: Remove failing legacy CLSID tests.

Modern Windows fails these tests, and no application is known to need
this behavior.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52998
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/xaudio2_7/tests/xaudio2.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/dlls/xaudio2_7/tests/xaudio2.c b/dlls/xaudio2_7/tests/xaudio2.c
index 9d50944b8d3..f4f808c2656 100644
--- a/dlls/xaudio2_7/tests/xaudio2.c
+++ b/dlls/xaudio2_7/tests/xaudio2.c
@@ -1067,10 +1067,6 @@ static void test_xapo_creation_modern(const char *module)
 
     /* CLSIDs are the same across all versions */
     static const GUID *const_clsids[] = {
-        &CLSID_FXEQ27,
-        &CLSID_FXMasteringLimiter27,
-        &CLSID_FXReverb27,
-        &CLSID_FXEcho27,
         &CLSID_FXEQ,
         &CLSID_FXMasteringLimiter,
         &CLSID_FXReverb,
@@ -1111,19 +1107,6 @@ static void test_xapo_creation_modern(const char *module)
             IUnknown_Release(fx_unk);
     }
 
-    /* test legacy CLSID */
-    hr = pCreateFX(&CLSID_AudioVolumeMeter27, &fx_unk, NULL, 0);
-    ok(hr == S_OK, "%s: CreateFX(CLSID_AudioVolumeMeter) failed: %08lx\n", module, hr);
-    if(SUCCEEDED(hr)){
-        IXAPO *xapo;
-        hr = IUnknown_QueryInterface(fx_unk, &IID_IXAPO, (void**)&xapo);
-        ok(hr == S_OK, "Couldn't get IXAPO interface: %08lx\n", hr);
-        if(SUCCEEDED(hr))
-            IXAPO_Release(xapo);
-        rc = IUnknown_Release(fx_unk);
-        ok(rc == 0, "XAPO via legacy CreateFX should have been released, got refcount: %lu\n", rc);
-    }
-
     pCAVM = (void*)GetProcAddress(xaudio2dll, "CreateAudioVolumeMeter");
     ok(pCAVM != NULL, "%s did not have CreateAudioVolumeMeter?\n", module);
 




More information about the wine-cvs mailing list