Francois Gouget : testbot/cgi: Don't pass the master columns to the list page.

Alexandre Julliard julliard at winehq.org
Tue Jun 7 15:37:01 CDT 2022


Module: tools
Branch: master
Commit: 352c2c7ba2830aafef52ec6cdfd7a0e87a25bed7
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=352c2c7ba2830aafef52ec6cdfd7a0e87a25bed7

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Jun  7 18:49:49 2022 +0200

testbot/cgi: Don't pass the master columns to the list page.

ItemPage ignores any master column parameter that it might receive so
RedirectToList() has nothing to pass on. CollectionPage would ignore
the master column parameters anyway.
Fortunately this functionality is not used and not needed.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/CGI/ItemPage.pm | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index b4d79e7..690458e 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -129,17 +129,7 @@ sub RedirectToList($)
 {
   my ($self) = @_;
 
-  my $Target = $self->{Collection}->GetCollectionName() . "List.pl";
-  my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
-  if (defined($MasterColNames))
-  {
-    foreach my $ColIndex (0..$#{$MasterColNames})
-    {
-      $Target .= ($ColIndex == 0 ? "?" : "&") . $MasterColNames->[$ColIndex] .
-                 "=" . url_escape($MasterColValues->[$ColIndex]);
-    }
-  }
-  return $self->Redirect($Target);
+  return $self->Redirect($self->{Collection}->GetCollectionName() . "List.pl");
 }
 
 sub OnAction($$)




More information about the wine-cvs mailing list