Francois Gouget : testbot: Empty configuration regexps match any configuration.

Alexandre Julliard julliard at winehq.org
Fri Jun 17 14:44:39 CDT 2022


Module: tools
Branch: master
Commit: 23f7f716a869553d0a0e7ab54a066a4f36614936
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=23f7f716a869553d0a0e7ab54a066a4f36614936

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Jun 17 16:50:03 2022 +0200

testbot: Empty configuration regexps match any configuration.

Unlike the failure regexps which must not be empty.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/LogUtils.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 720482f3..9e73b5f6 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -1390,7 +1390,7 @@ sub MatchLogFailures($$)
   {
     # Ignore failures that don't apply to this configuration
     my $ConfigRegExp = $Failure->ConfigRegExp;
-    my $Match = eval { $ConfigRegExp and $ConfigName =~ /$ConfigRegExp/ };
+    my $Match = eval { !$ConfigRegExp or $ConfigName =~ /$ConfigRegExp/ };
     next if (!$Match);
 
     my $UnitFailures = $FailureTree{$Failure->ErrorGroup}->{$Failure->TestUnit} ||= [];




More information about the wine-cvs mailing list