Francois Gouget : testbot/cgi: Remove the Cancel action from collection pages.
Alexandre Julliard
julliard at winehq.org
Wed Mar 2 14:36:02 CST 2022
Module: tools
Branch: master
Commit: 7cba9ec2de2ea760adbb55de05da10d9932d911a
URL: https://source.winehq.org/git/tools.git/?a=commit;h=7cba9ec2de2ea760adbb55de05da10d9932d911a
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Wed Mar 2 16:59:53 2022 +0100
testbot/cgi: Remove the Cancel action from collection pages.
What this action would do is not defined, it has not been implemented
and there does not seem to be a need for it.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
index 058bb47..effd039 100644
--- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
+++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
@@ -391,11 +391,6 @@ sub GetActions($)
{
$Actions[0] = "Add " . $self->{Collection}->GetItemName();
}
- my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
- if (defined($MasterColNames))
- {
- push @Actions, "Cancel";
- }
return \@Actions;
}
@@ -506,11 +501,7 @@ sub OnAction($$)
{
my ($self, $Action) = @_;
- if ($Action eq "Cancel")
- {
- # FIXME Todo
- }
- elsif ($Action eq "Add " . $self->{Collection}->GetItemName())
+ if ($Action eq "Add " . $self->{Collection}->GetItemName())
{
my $Target = $self->CallGetDetailsPage();
my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
More information about the wine-cvs
mailing list