Francois Gouget : testbot/cgi: !1 is really an empty string in FormPage::SaveProperties().

Alexandre Julliard julliard at winehq.org
Mon Mar 7 15:45:32 CST 2022


Module: tools
Branch: master
Commit: aa8d29559c08cbab0b750278cd506f49c0330f34
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=aa8d29559c08cbab0b750278cd506f49c0330f34

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Mar  7 12:46:21 2022 +0100

testbot/cgi: !1 is really an empty string in FormPage::SaveProperties().

So the point of that SaveProperty() call is that if an editable property
value was not received as a form parameter it is considered to be an
empty string.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/CGI/FormPage.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index 43b9b59..21c8631 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -375,7 +375,7 @@ sub SaveProperties($)
         $self->DisplayProperty($PropertyDescriptor) eq "rw" &&
         ! defined($self->GetParam($PropertyDescriptor->GetName())))
     {
-      if (! $self->SaveProperty($PropertyDescriptor, !1))
+      if (! $self->SaveProperty($PropertyDescriptor, ""))
       {
         return !1;
       }




More information about the wine-cvs mailing list