Francois Gouget : testbot/web: Simplify the Log page Download action handling.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 68f44aa47e9de1a37fd387e37584932346ba1e47
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=68f44aa47e9de1a37fd387e37584932346ba1e47

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Mar 10 12:00:42 2022 +0100

testbot/web: Simplify the Log page Download action handling.

The action is pretty simple so there is no need for a separate function.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/admin/Log.pl | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/testbot/web/admin/Log.pl b/testbot/web/admin/Log.pl
index f8e4943..ddc655f 100644
--- a/testbot/web/admin/Log.pl
+++ b/testbot/web/admin/Log.pl
@@ -65,18 +65,14 @@ sub GetActions($)
   return ["Download"];
 }
 
-sub OnDownload($)
-{
-  my ($self) = @_;
-
-  exit($self->Redirect("/admin/SendLog.pl?Hours=". $self->GetParam("Hours")));
-}
-
 sub OnAction($$)
 {
   my ($self, $Action) = @_;
 
-  return $self->OnDownload() if ($Action eq "Download");
+  if ($Action eq "Download")
+  {
+    exit($self->Redirect("/admin/SendLog.pl?Hours=". $self->GetParam("Hours")));
+  }
   return $self->SUPER::OnAction($Action);
 }