Francois Gouget : testbot/web: Simplify action handling in the Stats page.

Alexandre Julliard julliard at winehq.org
Thu Mar 10 16:09:37 CST 2022


Module: tools
Branch: master
Commit: 36c9bda83b4ed62e2476cfca54ffac41a1783702
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=36c9bda83b4ed62e2476cfca54ffac41a1783702

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Mar 10 12:00:52 2022 +0100

testbot/web: Simplify action handling in the Stats page.

The action is a no-op so unset it to not need to redefine OnAction().

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/Stats.pl | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/testbot/web/Stats.pl b/testbot/web/Stats.pl
index 42408a3..5ec6979 100644
--- a/testbot/web/Stats.pl
+++ b/testbot/web/Stats.pl
@@ -49,6 +49,8 @@ sub _initialize($$$)
     $self->SetParam("Days", 7) if (!defined $self->{ErrMessage});
     $self->{NoStats} = 1;
   }
+  # The action is a no-op so unset it to not need to redefine OnAction()
+  $self->SetParam("Action", undef);
 }
 
 sub GetPageTitle($$)
@@ -367,18 +369,6 @@ sub GetActions($)
   return ["Update"];
 }
 
-sub OnAction($$)
-{
-  my ($self, $Action) = @_;
-
-  if ($Action eq "Update")
-  {
-    return $self->Validate() ? 1 : undef;
-  }
-
-  return $self->SUPER::OnAction($Action);
-}
-
 sub GenerateFooter($)
 {
   my ($self) = @_;




More information about the wine-cvs mailing list