Rémi Bernon : winegstreamer: Return S_OK from H264 decoder GetAttributes.

Alexandre Julliard julliard at winehq.org
Tue Mar 15 17:57:48 CDT 2022


Module: wine
Branch: master
Commit: 2d7c37da495cc25d14f5b2761a5d7e2a2111320a
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=2d7c37da495cc25d14f5b2761a5d7e2a2111320a

Author: Rémi Bernon <rbernon at codeweavers.com>
Date:   Mon Mar 14 12:09:04 2022 +0100

winegstreamer: Return S_OK from H264 decoder GetAttributes.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45988
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47084
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49715
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52183
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mf/tests/mf.c                | 2 --
 dlls/winegstreamer/h264_decoder.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c
index de72ad5a6e7..0b089b74a5f 100644
--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -6665,9 +6665,7 @@ static void test_h264_decoder(void)
         goto failed;
 
     hr = IMFTransform_GetAttributes(transform, &attributes);
-    todo_wine
     ok(hr == S_OK, "GetAttributes returned %#lx\n", hr);
-    if (hr != S_OK) MFCreateAttributes(&attributes, 0);
     hr = IMFAttributes_SetUINT32(attributes, &MF_LOW_LATENCY, 1);
     ok(hr == S_OK, "SetUINT32 returned %#lx\n", hr);
     IMFAttributes_Release(attributes);
diff --git a/dlls/winegstreamer/h264_decoder.c b/dlls/winegstreamer/h264_decoder.c
index 2fafaea4fff..fdc0d6addeb 100644
--- a/dlls/winegstreamer/h264_decoder.c
+++ b/dlls/winegstreamer/h264_decoder.c
@@ -119,7 +119,7 @@ static HRESULT WINAPI transform_GetOutputStreamInfo(IMFTransform *iface, DWORD i
 static HRESULT WINAPI transform_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
 {
     FIXME("iface %p, attributes %p stub!\n", iface, attributes);
-    return E_NOTIMPL;
+    return MFCreateAttributes(attributes, 0);
 }
 
 static HRESULT WINAPI transform_GetInputStreamAttributes(IMFTransform *iface, DWORD id, IMFAttributes **attributes)




More information about the wine-cvs mailing list