Francois Gouget : testbot/cgi: Remove the PageBase::SetCurrentSession() $Page parameter.

Alexandre Julliard julliard at winehq.org
Mon Mar 28 15:48:29 CDT 2022


Module: tools
Branch: master
Commit: 78809ac6fe37b332b71e14bfe521b9c9e03d526e
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=78809ac6fe37b332b71e14bfe521b9c9e03d526e

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Mar 28 17:29:12 2022 +0200

testbot/cgi: Remove the PageBase::SetCurrentSession() $Page parameter.

It is unused and there is no indication it may be needed one day.
With that change none of the 'session management' methods take a $Page
parameter.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/CGI/Page.pm     | 2 +-
 testbot/lib/WineTestBot/CGI/PageBase.pm | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm
index 014324f..d587412 100644
--- a/testbot/lib/ObjectModel/CGI/Page.pm
+++ b/testbot/lib/ObjectModel/CGI/Page.pm
@@ -241,7 +241,7 @@ sub SetCurrentSession($$)
 {
   my ($self, $Session) = @_;
 
-  $self->{PageBase}->SetCurrentSession($self, $Session);
+  $self->{PageBase}->SetCurrentSession($Session);
 }
 
 sub Redirect($$)
diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm
index cab14e1..695dde3 100644
--- a/testbot/lib/WineTestBot/CGI/PageBase.pm
+++ b/testbot/lib/WineTestBot/CGI/PageBase.pm
@@ -224,9 +224,9 @@ sub GetCurrentSession($)
   return $self->{Session};
 }
 
-sub SetCurrentSession($$$)
+sub SetCurrentSession($$)
 {
-  my ($self, $Page, $Session) = @_;
+  my ($self, $Session) = @_;
 
   $self->{Session} = $Session;
   if (! defined($Session))




More information about the wine-cvs mailing list