Francois Gouget : testbot/web: Document why ErrField is not set when failing to delete an item.
Alexandre Julliard
julliard at winehq.org
Wed Mar 30 15:17:55 CDT 2022
Module: tools
Branch: master
Commit: 5adffdb0f644c9434fef9db53dcad9d5dcab251a
URL: https://source.winehq.org/git/tools.git/?a=commit;h=5adffdb0f644c9434fef9db53dcad9d5dcab251a
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Wed Mar 30 19:02:45 2022 +0200
testbot/web: Document why ErrField is not set when failing to delete an item.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
testbot/web/admin/UsersList.pl | 3 ++-
testbot/web/admin/VMsList.pl | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/testbot/web/admin/UsersList.pl b/testbot/web/admin/UsersList.pl
index 019bc63..ae514e9 100644
--- a/testbot/web/admin/UsersList.pl
+++ b/testbot/web/admin/UsersList.pl
@@ -117,7 +117,8 @@ sub OnItemAction($$$$)
if ($Action eq "Delete")
{
$User->Status('deleted');
- (my $ErrProperty, $self->{ErrMessage}) = $User->Save();
+ # Setting $self->{ErrField} is only useful on form pages
+ (my $_ErrProperty, $self->{ErrMessage}) = $User->Save();
return 0 if (defined $self->{ErrMessage});
# Forcefully log out that user by deleting the web sessions
diff --git a/testbot/web/admin/VMsList.pl b/testbot/web/admin/VMsList.pl
index 0ed0b0d..1895225 100644
--- a/testbot/web/admin/VMsList.pl
+++ b/testbot/web/admin/VMsList.pl
@@ -59,7 +59,8 @@ sub OnItemAction($$$$)
if ($Action eq "Delete")
{
$VM->Role("deleted");
- (my $ErrProperty, $self->{ErrMessage}) = $VM->Save();
+ # Setting $self->{ErrField} is only useful on form pages
+ (my $_ErrProperty, $self->{ErrMessage}) = $VM->Save();
return !defined $self->{ErrMessage};
}
More information about the wine-cvs
mailing list