Nikolay Sivov : scrobj: Fix wrong cleanup logic for factory object.

Alexandre Julliard julliard at winehq.org
Wed Mar 30 15:43:56 CDT 2022


Module: wine
Branch: master
Commit: 5aab379debfbdc11ebf5c5467c3edaa15de75f26
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=5aab379debfbdc11ebf5c5467c3edaa15de75f26

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Mar 30 08:55:48 2022 +0300

scrobj: Fix wrong cleanup logic for factory object.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/scrobj/scrobj.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/scrobj/scrobj.c b/dlls/scrobj/scrobj.c
index b01fa60d6a4..90cf2024537 100644
--- a/dlls/scrobj/scrobj.c
+++ b/dlls/scrobj/scrobj.c
@@ -1883,10 +1883,7 @@ static HRESULT create_scriptlet_factory(const WCHAR *url, struct scriptlet_facto
     TRACE("%s\n", debugstr_w(url));
 
     if (!(factory = calloc(1, sizeof(*factory))))
-    {
-        IClassFactory_Release(&factory->IClassFactory_iface);
         return E_OUTOFMEMORY;
-    }
 
     factory->IClassFactory_iface.lpVtbl = &scriptlet_factory_vtbl;
     factory->ref = 1;




More information about the wine-cvs mailing list