Francois Gouget : winetest/build-patterns: Use CSS to highlight the new failure modes.

Alexandre Julliard julliard at winehq.org
Thu May 5 13:48:31 CDT 2022


Module: tools
Branch: master
Commit: 96a6a0db927096e2069998a0b752ead28978951d
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=96a6a0db927096e2069998a0b752ead28978951d

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu May  5 16:57:21 2022 +0200

winetest/build-patterns: Use CSS to highlight the new failure modes.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 winetest/build-patterns | 20 ++++++++++++--------
 winetest/report.css     |  4 ++++
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/winetest/build-patterns b/winetest/build-patterns
index aa6a6e4..b6e5531 100755
--- a/winetest/build-patterns
+++ b/winetest/build-patterns
@@ -999,7 +999,7 @@ sub write_newmodes_line($$)
     foreach my $status (sort cmpstatus keys %{$test->{newmodes}})
     {
         my ($symbol, $class, $title, $_link, $attrs) = get_status_html($status, $test->{colors});
-        print $html " <span class='pat$class'$attrs title='$title'><b><i>$symbol</i></b></span>";
+        print $html " <span class='pat$class newM'$attrs title='$title'>$symbol</span>";
     }
     print $html "\n";
 }
@@ -1016,7 +1016,7 @@ sub write_pattern_line($$$)
     my ($range_start, $range_end, $range_title);
     foreach my $build (@sortedbuilds)
     {
-        my ($symbol, $class, $title);
+        my ($symbol, $class, $title, $is_new_mode);
         my ($tag, $attrs) = ("span", "");
         my $status = $testreport->{status}->{$build->{name}};
 
@@ -1066,11 +1066,7 @@ sub write_pattern_line($$$)
                 $attrs .= sprintf " href='%s/%s/%s.html#%s'",
                                   $build->{name}, $reportdir, $link, $dll;
             }
-            if ($test->{newmodes}->{$status})
-            {
-                $symbol = "<b><i>$symbol</i></b>";
-                $has_newmode = 1;
-            }
+            $is_new_mode = $test->{newmodes}->{$status};
         }
 
         if ($range_symbol eq $symbol)
@@ -1091,7 +1087,15 @@ sub write_pattern_line($$$)
             }
 
             # Start a new pattern range
-            $class = " class='pat$class'" if ($class);
+            if ($is_new_mode)
+            {
+                $class = $class ? " class='pat$class newM'" : " class='newM'";
+                $has_newmode = 1;
+            }
+            elsif ($class)
+            {
+                $class = " class='pat$class'";
+            }
             print $html "<$tag$class$attrs";
             if ($tag eq "a")
             {
diff --git a/winetest/report.css b/winetest/report.css
index 25f156d..4b2d126 100644
--- a/winetest/report.css
+++ b/winetest/report.css
@@ -134,6 +134,10 @@ div.pattern :hover   { color: black; text-decoration: underline; }
 .patV { /* test blocked by the anti-virus */
     background-color: #99e6ff;
 }
+.newM { /* new failure mode */
+    font-style: italic;
+    font-weight: bold;
+}
 
 .commitR {
     color: #cc0000;




More information about the wine-cvs mailing list