Francois Gouget : testbot: Use GetSortedItems() to sort the Steps.

Alexandre Julliard julliard at winehq.org
Mon May 30 15:31:27 CDT 2022


Module: tools
Branch: master
Commit: 068575b74b9d655869a1e43473f01b0b34ba588f
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=068575b74b9d655869a1e43473f01b0b34ba588f

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon May 30 18:44:06 2022 +0200

testbot: Use GetSortedItems() to sort the Steps.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/Jobs.pm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index 82cac66..778a0f4 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -218,8 +218,7 @@ sub UpdateStatus($)
 
   my %Has;
   my $Steps = $self->Steps->Clone();
-  my @SortedSteps = sort { $a->No <=> $b->No } @{$Steps->GetItems()};
-  foreach my $Step (@SortedSteps)
+  foreach my $Step (@{$Steps->GetSortedItems()})
   {
     my $Skip;
     if ($Step->PreviousNo)
@@ -419,8 +418,7 @@ sub Restart($)
   }
 
   my $Steps = $self->Steps;
-  my @SortedSteps = sort { $a->No <=> $b->No } @{$Steps->GetItems()};
-  foreach my $Step (@SortedSteps)
+  foreach my $Step (@{$Steps->GetSortedItems()})
   {
     my $Tasks = $Step->Tasks;
     foreach my $Task (@{$Tasks->GetItems()})




More information about the wine-cvs mailing list