Hans Leidekker : mshtml: Implement HTMLStorage_removeItem().

Alexandre Julliard julliard at winehq.org
Mon May 30 15:34:57 CDT 2022


Module: wine
Branch: master
Commit: 617ea8b930b7223af87111a24b0fad552b24874f
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=617ea8b930b7223af87111a24b0fad552b24874f

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Mon May 30 10:29:48 2022 +0200

mshtml: Implement HTMLStorage_removeItem().

Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/htmlstorage.c | 56 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 54 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/htmlstorage.c b/dlls/mshtml/htmlstorage.c
index f7b92114622..1983d87a296 100644
--- a/dlls/mshtml/htmlstorage.c
+++ b/dlls/mshtml/htmlstorage.c
@@ -454,11 +454,63 @@ static HRESULT WINAPI HTMLStorage_setItem(IHTMLStorage *iface, BSTR bstrKey, BST
     return hres;
 }
 
+static HRESULT remove_item(const WCHAR *filename, BSTR key)
+{
+    IXMLDOMDocument *doc;
+    IXMLDOMNode *root = NULL, *node = NULL;
+    BSTR query = NULL;
+    HRESULT hres;
+
+    hres = open_document(filename, &doc);
+    if(hres != S_OK)
+        return hres;
+
+    hres = get_root_node(doc, &root);
+    if(hres != S_OK)
+        goto done;
+
+    query = build_query(key);
+    if(!query) {
+        hres = E_OUTOFMEMORY;
+        goto done;
+    }
+
+    hres = IXMLDOMNode_selectSingleNode(root, query, &node);
+    if(hres == S_OK) {
+        hres = IXMLDOMNode_removeChild(root, node, NULL);
+        if(hres != S_OK)
+            goto done;
+    }
+
+    hres = save_document(doc, filename);
+
+done:
+    SysFreeString(query);
+    if(root)
+        IXMLDOMNode_Release(root);
+    if(node)
+        IXMLDOMNode_Release(node);
+    IXMLDOMDocument_Release(doc);
+    return hres;
+}
+
 static HRESULT WINAPI HTMLStorage_removeItem(IHTMLStorage *iface, BSTR bstrKey)
 {
     HTMLStorage *This = impl_from_IHTMLStorage(iface);
-    FIXME("(%p)->(%s)\n", This, debugstr_w(bstrKey));
-    return E_NOTIMPL;
+    HRESULT hres;
+
+    TRACE("(%p)->(%s)\n", This, debugstr_w(bstrKey));
+
+    if(!This->filename) {
+        FIXME("session storage not supported\n");
+        return E_NOTIMPL;
+    }
+
+    WaitForSingleObject(This->mutex, INFINITE);
+    hres = remove_item(This->filename, bstrKey);
+    ReleaseMutex(This->mutex);
+
+    return hres;
 }
 
 static HRESULT WINAPI HTMLStorage_clear(IHTMLStorage *iface)




More information about the wine-cvs mailing list