edit control patch

James Hatheway james at macadamian.com
Wed Apr 11 21:47:06 CDT 2001

Just one little comment, you should make your diffs using the -u
(unified diff) option.

(ie. cvs -d $CVSROOT -u controls/edit.c > newdiff.diff)

That way your patch has "+"s and "-"s instead of ">"s.  It makes it easier
to read what is changing in the patch...

(For example, you patch will look something like this instead:)
+ INT BkMode;
+ BkMode = GetBkMode(dc);
+ SetBkMode( dc, OPAQUE);
+ SetBkMode( dc, BkMode);

James Hatheway
Work: james at macadamian.com ~ http://www.macadamian.com
Home: jhatheway at home.com ~ http://members.home.net/jhatheway

  "Man könnte froh sein, wenn die Luft so rein wäre wie das Bier"
  "One could be happy if the air were as pure as the beer"

----- Original Message -----
From: "Dan Engel" <dengel at sourceharvest.com>
To: <wine-patches at winehq.com>
Sent: Wednesday, April 11, 2001 10:24 PM
Subject: edit control patch

> This is my first attempt at submitting a patch--please someone let me know if there are "customs" I need to follow.
> Problem: Edit boxes are, in some cases, displaying selected text as white-on-white, so that it disappeared.
> Analysis: When text is drawn using the x11drv function X11DRV_ExtTextOut, the function does not paint a background
rectangle if the background mode for the device context is transparent.  In the case of edit controls, there is no
attempt to change the background mode to opaque for selected text.
> Solution: In the case of painting reverse text in the edit control (function EDIT_PaintText) set the backgound mode to
opaque, and then restore it before exiting the function.
> The patch is attached (wine.diff).

More information about the wine-devel mailing list