Review - Winnt.h warning patch for mingw32

Francois Gouget fgouget at free.fr
Thu Apr 4 15:35:29 CST 2002


On Fri, 5 Apr 2002, Dmitry Timoshkov wrote:

> "Steven Edwards" <Steven_Ed4153 at yahoo.com> wrote:
>
> > diff -u -r1.104 winnt.h
> > --- winnt.h 2 Apr 2002 19:37:15 -0000 1.104
> > +++ winnt.h 4 Apr 2002 08:15:55 -0000
> > @@ -80,9 +80,11 @@
> >  #ifndef __WINE__
> >  #define pascal      __stdcall
> >  #define _pascal     __stdcall
> > +#if ! defined(__WINE__) && !defined(__MINGW__)
> >  #define _stdcall    __stdcall
> >  #define _fastcall   __stdcall
> >  #define __fastcall  __stdcall
> > +#endif
> >  #define __export    __stdcall
> >  #define cdecl       __cdecl
> >  #define _cdecl      __cdecl
>
> Why don't you use something like this:
>
> +#if !defined(_stdcall)
>  #define _stdcall    __stdcall
>  #define _fastcall   __stdcall
>  #define __fastcall  __stdcall
> +#endif

   Is _stdcall going to be a macro? I would rather expect it to be a
reserved keyword like in Visual C++.
   Steven's patch looks good to me.



--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
 Advice is what we ask for when we already know the answer but wish we didn't
                                 -- Eric Jong




More information about the wine-devel mailing list