Make RECT === RECTL, fix compile warnings, use uniform format

[Dan Kegel]

Dimitrie O. Paun wrote:
> On December 28, 2002 04:10 pm, Dan Kegel wrote:
> 
>>Decided to leave debugrect for later, too much of a pain for now.
>>This patch just uses a uniform format for RECTs where possible.
>>It reorders three or so TRACEs that had the coordinates in
>>nonstandard order, too.  Patch against current CVS attached.
>>Should compile fine, but I haven't tested it (so do look it over :-)
> 
> 
> Cool stuff. Can you please turn this thing:
> 
> Index: dlls/comctl32/datetime.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/comctl32/datetime.c,v
> retrieving revision 1.34
> diff -d -u -r1.34 datetime.c
> --- dlls/comctl32/datetime.c	2 Dec 2002 18:11:00 -0000	1.34
> +++ dlls/comctl32/datetime.c	28 Dec 2002 20:43:22 -0000
> @@ -1098,7 +1098,7 @@
>    infoPtr->rcClient.bottom = HIWORD(lParam);
>    infoPtr->rcClient.right = LOWORD(lParam);
>  
> -  TRACE("Height=%d, Width=%d\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right);
> +  TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right);
> 
>    /* use DrawEdge to adjust the size of rcEdge to get rcDraw */
>    memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw));
> 
> Into a standard [(%ld,%ld)-(%ld,%ld)]?

Aw, let's leave that for when we do the debugrect() conversion.
Or you can do it if you like.  I think I'm done with RECT changes
for a while.  I'm trying to fix ShellExecute now, seems higher priority...

 > As for debugrect(), it seems like half of the printed rectangles are
 > in commctrl, so what we can do is use debugrect() in there without having
 > to introduce any infrastructure changes. We can do that after Alexandre
 > commits this change, so we don't cram too much stuff into one patch.

OK.  Yes, let's keep this first patch simple.

(BTW it might worth looking into a change to debugrect() to get
its storage on the stack, in a local variable of the TRACE() macro.
That'd avoid possible thread clashes (if you have too many threads,
the current way debugrect() gets storage might break...))

-- 
Dan Kegel
Linux User #78045
http://www.kegel.com