Fixing include quotes (was: Re: conformance test for ShellExecute)

Patrik Stridvall ps at leissner.se
Tue Dec 31 05:41:39 CST 2002


> On December 30, 2002 03:41 pm, Patrik Stridvall wrote:
> > I'm already on it by improving winapi_cleanup.
> 
> Very well, I've put you up for it instead. But make sure
> you don't over do it :) 

Well, for the future I have planned grouping and automatic
addition of #ifdef HAVE_ and that sort of things. That is
overdoing a little perhaps but it will look nicer. :-)

> It seems to me the algo is simple
> (if the include can not be accessed relative to the dir in
>  which the .c file is, change it to <>), 

This is that it already does I think.

Please try it out yourself.

> and the operation
> is really one time.

It depends what you mean by one time. People make mistakes.
winapi_cleanup does C++ comment to C comment conversion
and this is "one time" as well...

> So if you have something that works,
> let's just get the patch (and here I'm referring to the one
> that does the actual "" to <> change) in, and check this off.

I think it is better than Alexandre runs
	winapi_cleanup --include-quotes 
himself if he thinks it does the correct things.
If not please inform me what the problem is.

In my tree, the patch is over 800k.



More information about the wine-devel mailing list