Patch that broke SetFileAttributes

Jukka Heinonen jhei at iki.fi
Fri Jan 25 22:58:31 CST 2002


Fallout II requires that a certain file is located
on a CDROM drive. For some reason it checks this using
SetFileAttributes, which is supposed to fail on readonly
drives. This used to work until the following patch broke
this behaviour (message continues after the patch):

Index: file.c
===================================================================
RCS file: /home/wine/wine/win32/file.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- file.c      2001/05/14 20:09:39     1.26
+++ file.c      2001/05/18 23:18:25     1.27
@@ -104,7 +104,7 @@
     {
         FILE_SetDosError();
         MESSAGE("Wine ERROR: Couldn't set file attributes for existing file \"%s\". Check permissions or set VFAT \"quiet\" flag !\n", full_name.long_name);
-        return FALSE;
+        return TRUE;
     }
     return TRUE;
 }

The above patch obviously breaks Windows compatibility (and likely has a 
bug related to FILE_SetDosError). I would like to suggest that this patch 
is either removed or replaced with a patch that includes a C comment that 
properly documents reasons for this deliberate incompatibility and that 
either only affects non-CDROM drives or drives configured using
some magic flag in Wine configuration file.

-- 
Jukka Heinonen <http://www.iki.fi/jhei/>




More information about the wine-devel mailing list