Pajama Sam's unmanaged window

Ove Kaaven ovehk at ping.uio.no
Wed Jan 30 18:39:53 CST 2002


On Mon, 28 Jan 2002, Ori Pessach wrote:

> - Changed is_window_managed()'s default return value to TRUE

Perhaps remove the cruft this leaves behind, then.

> - In tooltips.c, TOOLTIPS_NCCreate(), I set the WS_EX_TOOLWINDOW bit in the 
> tooltip's dwExStyle field. This, I believe, is the right thing to do 
> regardless of WM considerations, since MSDN specifies that tooltip windows 
> have that bit set. 
> (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/CommCtls/ToolTip/Styles.asp)

Then I suggest you submit this piece of the patch to wine-patches
independently of the rest of this.

> - In menu.c, I replaced CreateWindowA() with CreateWindowExA(), passing 
> WS_EX_TOOLWINDOW as the first parameter. I'm not so sure about this one. I 
> don't know whether Windows does this (Win16 surely doesn't), and if it 
> doesn't, it might break apps that examine those bits.

Since this is probably not the case, perhaps it's better to check for the
popup menu class in is_window_managed(), something like

 if (GetClassLongA(win->hwndSelf, GCW_ATOM) == POPUPMENU_CLASS_ATOM) return FALSE;

> With these changes, Pajama Sam works correctly, except for the KDE panel 
> problem.

I'm currently looking at that issue.





More information about the wine-devel mailing list