dlls/advapi32/registry.c patch for RegEnumValuesA
Tony Lambregts
tony_lambregts at telusplanet.net
Thu Jul 4 18:51:46 CDT 2002
Max wrote:
>Here a patch that corrects a nasty bug in dll/advapi32/registry.c, causing
>AutoCAD R14 (and I guess other apps too...) to hang.
>
>Regards
>
>Max
>
>
>
>------------------------------------------------------------------------
>
>--- dlls/advapi32/registry.c Sat Jul 6 01:29:08 2002
>+++ /home/massimo/wine-patches/registry.c Sat Jul 6 01:35:32 2002
>@@ -1157,6 +1157,9 @@
> RtlUnicodeToMultiByteSize( &len, info->Name, info->NameLength );
> if (len >= *val_count)
> {
>+ /* CHANGELOG : 04.07.2002 by Max
>+ MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */
>
The comment is OK I suppose, but it is part of the change log. Change
log entries should not be part of the patch itself.
>+ *val_count = len + 1 ;
> status = STATUS_BUFFER_OVERFLOW;
> goto done;
> }
>@@ -1174,6 +1177,9 @@
> {
> if (len > *count)
> {
>+ /* CHANGELOG : 04.07.2002 by Max
>+ MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */
>
Same here.
>+ *count = len+1 ;
> status = STATUS_BUFFER_OVERFLOW;
> goto done;
> }
>
>
Sorry to nitpick could you resubmit something like this
----
This is the first part. This is where you can say what you did, and say
what you wanted to say, in as long and as rambling way as you want. It
is for expaining whatever you wanted to expain, why you wanted to do it
the way you wanted to do it section. next comes the change log . after
that your name and contact.
Change log: Change In RegEnumValueA, when the size for requested data
buffer is too small, function should return an error (as it did), and
also return correct buffer size (now it does).
Max max at veneto.co
-----
attched patch
More information about the wine-devel
mailing list