Fixing a regression test ...

Paul Millar paulm at astro.gla.ac.uk
Sat Jul 13 11:05:09 CDT 2002


On Fri, 12 Jul 2002, Duane Clark wrote:
> Paul Millar wrote:
> > ChangeLog:
> >   Replace references to D: (which might not exist) with C: (which we 
> >   assume does)
[cut: old patch]

> Actually, the purpose of that particular test was to check the behavior 
> when the supplied path is on a different drive from the current drive. 

Ooops.

> The current drive is presumably C:.

In my case, the current drive is F: but C: exists so that bit works fine.


> But the test should have tested for 
> the existence of drive D: before using it.

Ok, so if I've understood this correctly, some tests check behaviour with
whatever the current drive is (assumed to be C:), and some others check
behaviour with some other drive (currently D: is assumed to be valid).

I'll submit another patch that should remove these assumptions. The patch
works for me, but you might like to check I've not negated any of the
tests: I'm not sure I follow exactly what's being tested ..

Ta,

Paul.

----
Paul Millar




More information about the wine-devel mailing list