game patches

Lionel Ulmer lionel.ulmer at free.fr
Mon Jul 29 08:43:37 CDT 2002


I think these are WineX patches.. So you should clean the parts that are NOT
WineX specific and resubmit them only here.. Moreover, it is often preferred
(even recommanded) to NOT send a huge patch with a bunch of unrelated diffs
in it but atomic changes.

For example, why mix D3D changes, OpenGL changes and DGA2 changes
considering that they all are related to different games / applications ?

As for the pure WineX changes, I do not know where to submit :-)

For some changes, see my comments embedded..

                     Lionel

> --- wine-cvs/graphics/x11drv/opengl.c	Wed Aug 29 22:37:08 2001
> +++ wine/graphics/x11drv/opengl.c	Sat Jul 20 10:07:05 2002
> @@ -200,7 +200,7 @@
>    ppfd->nVersion = 1;
>    
>    /* These flags are always the same... */
> -  ppfd->dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_GENERIC_ACCELERATED;
> +  ppfd->dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_SWAP_COPY;
>    /* Now the flags extraced from the Visual */
>    ENTER_GL();
>    glXGetConfig(gdi_display, vis, GLX_DOUBLEBUFFER, &value); if (value) ppfd->dwFlags |= PFD_DOUBLEBUFFER;

Which application needs to have the 'PFD_SWAP_COPY' flag set ?

> --- wine-cvs/include/wingdi.h	Mon Apr 22 10:01:17 2002
> +++ wine/include/wingdi.h	Sat Jul 20 13:22:05 2002
> @@ -3345,6 +3345,39 @@
>  BOOL      WINAPI PolyTextOutW(HDC,PPOLYTEXTW,INT);
>  #define   PolyTextOut WINELIB_NAME_AW(PolyTextOut)
>  
> +/* These defines are used by wglSwapLayerBuffers */
> +#define WGL_SWAP_MAIN_PLANE (1 <<  0)
(snip)
> +    WARN("Following layers unhandled : %08x\n", fuPlanes);
> +  }
> +  
> +  return TRUE;
>  }
>  
>  /***********************************************************************

Well, this part is actually one of my patches submitted to WineHQ some time
ago :-)


>  # Prefix used for the local variables
> -$ext_prefix = "func_";
> +$ext_prefix = "";
>  # If set to 1, generate TRACEs for each OpenGL function
> -$gen_traces = 1;
> +$gen_traces = 0;

Why change the 'ext_prefix' ? I could understand that you want more speed
and remove the (mostly useless now) ENTER/LEAVE calls and the TRACES, but
that one I do not understand :-)

(big snip removed)

-- 
		 Lionel Ulmer - http://www.bbrox.org/



More information about the wine-devel mailing list