wine/ programs/rundll32/rundll32.c dlls/kernel ...
Martin Wilck
Martin.Wilck at Fujitsu-Siemens.com
Fri Nov 15 02:39:23 CST 2002
Am Fre, 2002-11-15 um 05.17 schrieb Alexandre Julliard:
> ChangeSet ID: 6302
> Modified files:
> programs/rundll32: rundll32.c
> dlls/kernel : computername.c
>
> Log message:
> Warning fixes.
Your compiler seems to issue more warnings than mine :-/
It is good to see these patches are really reviewed. The lenW thingy
is really embarrassing for me.
Two questions/remarks:
@@ -426,12 +426,13 @@
memcpy( name, buf, len );
name[len] = 0;
*size = len;
+ ret = TRUE;
This shouldn't be necessary because the whole block is executed only
if ret == TRUE.
}
}
__EXCEPT(page_fault)
{
SetLastError( ERROR_INVALID_PARAMETER );
- ret = FALSE;
+ return FALSE;
}
__ENDTRY
What is the point of this one? (applies also to the last hunk)
Martin
--
Martin Wilck Phone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck at Fujitsu-Siemens.com
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
More information about the wine-devel
mailing list