Fixed garbage in toolbar buttons

Duane Clark dclark at akamail.com
Mon Oct 14 12:28:16 CDT 2002


Dimitrie O. Paun wrote:
> On October 14, 2002 11:16 am, Carlos wrote:
> 
>>Then it has initted the bitmap, and with a SRCPAINT the result is
>>correct, but if it hasn't passed by this point, when it uses SRCPAINT
>>it mixes with the garbage in the buffer, because it wasn't cleared,
>>then in this case SRCCOPY looks like correct. Maybe that it should be
>>CLEAR+SRCAND+SRCPAINT?
> 
> 
> You are correct, my mistake, I'm sorry. In fact, I just realized it
> a little while after sending the message, and I just finished an
> alternative patch (attached to this message). You are right, we should
> just SRCCOPY the image if we don't have a solid background. My
> patch just does a small code cleanup (and updates comments) to make
> clear what we're doing. Can you please let me know if it works
> as advertised?
> 

Works for me.






More information about the wine-devel mailing list