PATCH: dlls/comctl32/listview.c

[Patrik Stridvall]

> On Mon, Oct 14, 2002 at 10:09:12PM +0200, Gerald Pfeifer wrote:
> > This is not ANSI/ISO C as far as I (and current GCC) know, so I hope
> > this straightforward fix is fine.
> > 
> > Gerald
> > 
> > ChangeLog:
> >   Avoid GCC-specific language extension.
> > 
> > Index: listview.c
> > ===================================================================
> > RCS file: /home/wine/wine/dlls/comctl32/listview.c,v
> > retrieving revision 1.224
> > diff -u -3 -p -r1.224 listview.c
> > --- listview.c	11 Oct 2002 23:34:32 -0000	1.224
> > +++ listview.c	14 Oct 2002 20:04:57 -0000
> > @@ -4467,6 +4467,7 @@ static LRESULT LISTVIEW_GetColumnWidth(L
> >  	break;
> >      default:
> >  	/* we don't have a 'column' in [SMALL]ICON mode */
> > +	;
> Warum nicht einfach ein break; ? Sieht irgendwie "korrekter" aus...

[Since when did we become a german speaking list? :-)
 I CAN read german to some extent but still...]

Because its 
(1) 5 characters shorter 
(2) Some compilers generate better code.
    An unnessary "branch" might be generated.

But sure, semantically it is not different
(providing of course the default is LAST of course).

Anyway, I don't really care either way. Do as you wish.