[PATCH] some dc:LockWindowUpdate work

Christian Neumair chris at gnome-de.org
Fri Oct 18 08:27:36 CDT 2002


Am Fre, 2002-10-18 um 00.19 schrieb Alexandre Julliard:
> Christian Neumair <chris at gnome-de.org> writes:
> 
> > this patch improves dc:LockWindowUpdate (windows/dce.c); locking
> > other windows still not possible, though.
> 
> Apart from removing the fixme this doesn't appear to change anything
> at all. What were you trying to fix?

-            /* Unlock lockedWnd */
-            /* FIXME: Do something */
+	    /* Unlock lockedWnd */
+	    lockedWnd = 0;
+	    
+	    USER_Unlock();
+	    return TRUE;

The version in HEAD actually doesn't unlock the window inside the
function but just exits the if loop. The patch adds an unlock function
(see msdn, when not passing hwnd, the active window should be unlocked)
and moves the stub to the place where it belongs. Basically this makes
the code easier to read. If you want we can remove the whole if (!hwnd)
code because if hwnd is 0, lockedWnd = hwnd does the right thing, too.

regs,
 Chris




More information about the wine-devel mailing list