[PATCH] Re: [PATCH] some dc:LockWindowUpdate work

Alexandre Julliard julliard at winehq.com
Fri Oct 18 12:58:25 CDT 2002

Christian Neumair <chris at gnome-de.org> writes:

> I see a reason: FIXME denotes that something should be fixed, but in
> this place we don't need to fix anything. I prepared a really small
> patch, have a look at it and tell me if you still find the cleanup
> obsolete. And I think it's not a good idea to tell the users that
> something has gone wrong (stub) while the desired action was taken
> without any problems.

But no desired action has taken place at all!  All we do is store the
window in an internal variable, but we don't lock the window updates
at all, which is the whole point of the function. So a fixme is
definitely appropriate.

Alexandre Julliard
julliard at winehq.com

More information about the wine-devel mailing list