memory/virtual.c: ROUND_SIZE() bugfix + .SYS loading
short at ucw.cz
Mon Sep 16 16:21:04 CDT 2002
On Mon, 16 Sep 2002 21:47:23 +0200, Alexandre Julliard wrote:
> Jan Kratochvil <short at ucw.cz> writes:
> > I had incorrect warnings "Section %.8s too large (%lx+%lx/%lx)" during loading
> > of some low-level system libraries. It got fixed by the attached
> > "wine-memory-virtual.c-too_large_section.diff" which changes (I think fixes)
> > ROUND_SIZE() behaviour. It also comments ROUND_ADDR() and ROUND_SIZE(), I hope
> > I guessed its intended description from the style of its usage around the code.
> No, ROUND_SIZE is supposed to return an aligned size, which you use
> together with an aligned address. The normal pattern is to use
> ROUND_SIZE and ROUND_ADDR together. We don't bother to round addresses
> in image mapping because all the code assumes the image has correct
> section alignment already.
"is to use ROUND_SIZE and ROUND_ADDR together."
&& "We don't bother to round addresses"
seems as a conflict for me - if you "don't bother" why do you use/have
ROUND_ADDR at all?
More information about the wine-devel