Implements languagegroups functions

Maxime Bellengé maxime.bellenge at laposte.net
Sat Apr 5 07:51:13 CST 2003


Thanks for the comments. I will change that.

Max

On Sat, 2003-04-05 at 12:15, Mike Hearn wrote:
> Hi, 
> 
> Just a few comments, things that have been mentioned to me so I should
> probably pass along :)
> 
> Here:
> -  FIXME("stub\n");
> -  SetLastError( ERROR_INVALID_PARAMETER );
> -  return FALSE;
> +  TRACE("\n");
> +
> +  unsigned int i,j,nStrLen;
> 
> Normally you'd put a TRACE with the parameters passed after the variable
> declarations, I think otherwise it might violate strict C. Also putting
> the parameters into the trace statement makes debugging easier as you
> don't have to decode a relay trace to see what was given.
> 
> Again, I'm not a C expert but I think it's invalid strict C to declare
> variables half way through a block, they all have to be at the top of
> the function together.
> 
> +  }
> +
> +  // 1 to 17 is the constants for LGRPID_xxx
> +  for(i=1;i<=17;i++) {
> +    sprintfW(val,valm,i);
> +    length = sizeof(installed);
> 
> Wine doesn't like C++ style comments (//) because some C compilers don't
> accept them, I think you have to use /* */
> 
> Not sure how rigidly this rule is followed though.
> 
> 
-- 
Maxime Bellengé <maxime.bellenge at laposte.net>




More information about the wine-devel mailing list