[resend] Allow use of MAP_TRYFIXED for better mmap()

Alexandre Julliard julliard at winehq.org
Thu Aug 28 12:41:03 CDT 2003

Todd Vierling <tv at pobox.com> writes:

> You have to bend over backwards to do the runtime check, and you sacrifice
> *maintainability* with the extra normally-dead code added to Wine.  I don't
> see a need to jump through extra hoops in this case.

I think that run-time checks are more maintainable that compile-time
checks, since it means the code gets exercised on all machines, so if
you break it it gets noticed at once. If you break something that's
inside a rarely used #ifdef block you may not find the problem until 6
months later. It's also a lot easier to follow the code if you don't
have to wonder which parts of it are actually compiled in.

Anyway it doesn't really matter for that specific issue, if you don't
feel the performance gain is worth the trouble that's your call. I was
just raising a general point that checking run-time features with
#ifdef is not a good idea, no matter how much autoconf encourages that

Alexandre Julliard
julliard at winehq.com

More information about the wine-devel mailing list