menu: nasty bug in menu tracking

[Andrew de Quincey]

On Thursday 04 December 2003 23:34, Alexandre Julliard wrote:
> Andrew de Quincey <adq_dvb at lidskialf.net> writes:
> > OK, I'll keep looking. I've printed out the coordinates I get in the
> > tracking loop. As soon as the popup menu is displayed, they are
> > immediately "off" by the position of the menu on the top of the screen.
> > Its fine on menus without popups.
>
> Probably the app is messing with the mouse capture.

You're right. If I comment out the SendMessage(..., WM_INITMENUPOPUP) in 
MENU_ShowSubPopup, it works properly with the original code. 

IDA *is* changing what has been captured. If I add a 
MENU_SetCapture(hwndOwner); just after the WM_INITMENUPOPUP is sent, this 
fixes the problem. Is this an acceptable solution?

> > Out of interest, why do you specifically have to use lParam? Since it is
> > (supposed to be) in screen coordinates, surely GetCursorPos() has to
> > return the same values?
>
> Some programs want to modify menu behavior by changing the message
> parameters, or even sending new messages that don't correspond to real
> events. And even if this wasn't the case, using GetCursorPos() is
> wrong since it returns the current mouse position, not the position at
> the time the message was generated.

Ah of course! I didn't think of that. Cool, thanks for the explanation.