Winspool errors with notepad

Dmitry Timoshkov dmitry at baikal.ru
Thu Feb 6 08:23:13 CST 2003


"Sylvain Petreolle" <spetreolle at yahoo.fr> wrote:

> > > In an attempt to revive this thread (since it broke printing for me
> > 
> > > too), it appears that if a NULL pointer is passed to:
> > > 
> > > RtlCreateUnicodeStringFromAsciiz(&pNameW,pName);
> > > 
> > > then it returns an empty string in pNameW.buffer, rather than NULL.
> > 
> > That's correct behaviour. We need to make checks for NULL everywhere
> > when appropriate before RtlCreateUnicodeStringFromAsciiz calls to
> > avoid
> > this kind of bug.

> wouldnt be better for this issue that we revert the patch ?

I don't think so. The patch does the right thing. Just it doesn't
take into account some not obvious cases, which can be relatively
simply found and fixed.

-- 
Dmitry.






More information about the wine-devel mailing list