Fixing include quotes (was: Re: conformance test for ShellExecute)

Patrik Stridvall ps at leissner.se
Wed Jan 1 12:40:31 CST 2003


> On December 31, 2002 06:41 am, Patrik Stridvall wrote:
> > I think it is better than Alexandre runs
> >         winapi_cleanup --include-quotes
> > himself if he thinks it does the correct things.
> 
> Well, that's cool, but your original message gave the impression
> that this is still a work in progress not ready to be used.

It does (save bugs) what I want it to do. 
However I not sure that it does is the correct thing.

> Which it seems is the wrong impression. Just let Alexandre know
> to run the above mentioned command after applying your patch,
> that will do.
> 
> BTW, did you compile Wine after this patch? 

Yes. It compiles fine.

> If it compiles,
> then I don't think there is any problem, no? In fact, if it
> compiles we are *guaranteed* that the result is correct
> because we don't have any duplicated header filename:
> 
> [dimi at dimi wine.src]$ find -name "*.h" | sed 's%.*/%%' | sort 
> -u | uniq -c | sort -rn | head -1
>       1 zmouse.h

We some more duplicates that that. However I have look at them
quickly manually and I don't think they matter.



More information about the wine-devel mailing list