Make RECT === RECTL, fix compile warnings, use uniform format

Dimitrie O. Paun dpaun at rogers.com
Thu Jan 2 10:51:00 CST 2003


On January 2, 2003 12:41 pm, Alexandre Julliard wrote:
> What we need is to export that functionality
> through a more generic interface so that we can implement all kinds of
> debug* functions on top of it. I'll look into that.

Excellent -- this is the infrastructure change I was referring to
in my emails. This is perfect: if you can export that, I can then
look into providing some more debug* functions.

Make sure we somehow know the size of the returned buffer. Either
by a constant, or providing a minimum length argument:
  char *debug_getbuffer(int size);

If the allocation can not be met, we should just crash the program.
This way we can maintain 2-4 sizes (32, 64, 256, 1024), and return
the closest one that is larger than size.

As for the new debug* functions, most nontrivial ones are not that
small. Do you want them defined as static inline in wine/debug.h,
or exported from ntdll as the other ones? In fact, why not create
a helper DLL (winedebug) that holds all of this, and that can be
used on Windows as well, when we port most of our stuff over?

-- 
Dimi.




More information about the wine-devel mailing list