Problem in dlls/ddraw/dsufrace/main.c

[Sylvain Petreolle]

> It will crash in the AddRef code. Better to try to do something like
> that :
> 
>     if (found == NULL) {
>        TRACE("Did not find any valid surface\n");
>        *ppSurface = NULL;
>        return DD_OK;
>     }
Thanks, I will try it.
But with the test disabled, I get no crash in AddRef (??).
See the following resuslts :
trace:ddraw:Main_DirectDrawSurface_GetAttachedSurface
(0x402a9418)->Looking for caps: 4,0,1,1 output: 0x741ed0
   Caps are : DDSCAPS_BACKBUFFER
trace:ddraw:Main_DirectDrawSurface_GetAttachedSurface Surface:
(0x402a9b38) caps: 1000601c,0,0,0
   Surface caps are : DDSCAPS_BACKBUFFER DDSCAPS_COMPLEX DDSCAPS_FLIP
DDSCAPS_3DDEVICE DDSCAPS_VIDEOMEMORY DDSCAPS_LOCALVIDMEM
trace:ddraw:Main_DirectDrawSurface_GetAttachedSurface Returning surface
0x402a9b38 with description :
 - DDSD_CAPS : DDSCAPS_BACKBUFFER DDSCAPS_COMPLEX DDSCAPS_FLIP
DDSCAPS_3DDEVICE DDSCAPS_VIDEOMEMORY DDSCAPS_LOCALVIDMEM
 - DDSD_HEIGHT : 480
 - DDSD_WIDTH : 640
 - DDSD_PITCH : 1280
 - DDSD_LPSURFACE : 0x424b0000
 - DDSD_PIXELFORMAT : ( DDPF_RGB , RGB bits: 16,  R f800 G 07e0 B 001f)
trace:ddraw:Main_DirectDrawSurface_AddRef (0x402a9b38)->(): increasing
from 1
trace:ddraw:Main_DirectDrawSurface_AddAttachedSurface
(0x402a9b38)->(0x402a90e8)
trace:ddraw:Main_DirectDrawSurface_AddRef (0x402a90e8)->(): increasing
from 1
The only err: that I get inddraw trace are unhandled dwRenderStateType.

Argh, cant do it for now. 
> To be 100 %, the best would be for one to do a test in real Windows
> and
> check what happens when asking for a non-existant attached surface
> and check
> what happens (ie DD_OK with ppSurface being NULL or DDERR_NOTFOUND).
> 
> > The reason I write is that : in fact, I disabled the failing test
> and
> > the game (Re-Volt Demo) begins to start.
> 
> Well, as said before, try to see if this call SHOULD fail or if it's
> a bug
> that we do not find this attached surface.
> 
> Even better would be to disassemble the code handling the return of
> this
> function to see what kind of stuff the game expects.
> 
>                         Lionel
> 
> -- 
> 		 Lionel Ulmer - http://www.bbrox.org/ 

=====
Sylvain Petreolle
spetreolle at users.sourceforge.net 
Fight against Spam ! http://www.euro.cauce.org/en/index.html
ICQ #170597259

"Don't think you are. Know you are." Morpheus in Matrix, chapter 15.

___________________________________________________________
Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français !
Yahoo! Mail : http://fr.mail.yahoo.com