Oleaut32 Debug Messages

Alexandre Julliard julliard at winehq.com
Thu Mar 13 14:45:44 CST 2003


Jon Griffiths <jon_p_griffiths at yahoo.com> writes:

> Hence my suggestion to only use MESSAGE and DPRINTF inside dumping
> functions that can be elimated with macros. But as far as cosmetics
> go, i don't see how TMSG and TMS2 are any more ugly than MESSAGE.
> Check the code before the patch, its just as bad...

Well at least MESSAGE accepts varargs arguments...

Maybe part of the problem is that there is confusion between DPRINTF
and MESSAGE, since both do the same thing right now. MESSAGE should be
used for things that are always displayed, while DPRINTF is for debug
output. We could certainly have DPRINTF do nothing when trace messages
are compiled out; but this will require going through all the calls to
make sure we use the right macro in each case.

-- 
Alexandre Julliard
julliard at winehq.com



More information about the wine-devel mailing list