Oleaut32 Debug Messages
Alexandre Julliard
julliard at winehq.com
Thu Mar 13 16:58:20 CST 2003
"Dimitrie O. Paun" <dimi at intelliware.ca> writes:
> There are 767 DPRINTFs, and 736 MESSAGEs. I think DPRINTFs should just die,
> they are confusing, it's not clear what they output, etc. Your patch is just
> perfect, as it does the obvious thing the user expects. I think we can just
> turn most of the DPRINTFs into TRACEs, but we need to do that manually. If we
> do so, we could probably also simplify the code in certain places, so a manual
> process is better (in fact, a search & replace is the worse combination, as
> we'd simply lose track of the places we need to audit).
I agree most of them can be replaced by TRACE, but not all of them.
There are cases where we want to dump debug output without the
standard header; relay output is the obvious example. So I think a
DPRINTF that can be compiled out would still be useful.
--
Alexandre Julliard
julliard at winehq.com
More information about the wine-devel
mailing list