gethostbyname patch

[Andreas Mohr]

On Tue, May 06, 2003 at 10:07:34AM -0400, Dimitrie O. Paun wrote:
> On Tue, 6 May 2003, Andreas Mohr wrote:
> 
> > +    if (name == NULL)
> > +    {
> > +	if (WS_gethostname(local_name, sizeof(local_name)) != 0)
> > +		FIXME("failed to get local host name, please report!\n");
> 
> There is nothing to fix here. This is at most a WARN, but if
> WS_gethostname() is documented as possibly failing, that's
> just fine, no need for any message, just return failure:
> 
> +     if (WS_gethostname(local_name, sizeof(local_name))) return NULL;
I beg to differ a slightly minuscule bit.
In the case that 256 chars is not enough, it's probably good to have
a FIXME, since it's a local problem of this function (insufficient buffer).
And as this failure is unlikely, it shouldn't be too annoying.

-- 
Andreas Mohr                        Stauferstr. 6, D-71272 Renningen, Germany
Tel. +49 7159 800604                http://mohr.de.tt