Crash on imm32

Raphaël Junqueira fenix at club-internet.fr
Wed May 14 20:17:48 CDT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ok,

patch attached and it works perfectly with warcraft3 ;)

Changelog:
 - fix a warcraft3 crash when using unitialised imm apis

Thx,
Raphael

> Whoops, looks like i forgot to put in that protection when i coded that
> section.
>
> This fix is exactly what you need, i did it most other places that data
> is used i just missed this one.
>
> thanks
> -aric
>
> Mike Hearn wrote:
> > You could just protect it with a
> >
> > if (!data) return FALSE;
> >
> > If I had CVS access at work (stupid corporate politics) I'd submit it
> > myself, not a hard fix....
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+wuq9p7NA3AmQTU4RAsNtAJoChN4DWVJZX4LREO0H1g0C+zV8UwCff+yJ
4lXMOs52Y1Xi4KeErsbM9io=
=1y6B
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: imm.c
===================================================================
RCS file: /home/wine/wine/dlls/imm32/imm.c,v
retrieving revision 1.21
diff -u -r1.21 imm.c
--- imm.c	13 May 2003 22:12:24 -0000	1.21
+++ imm.c	15 May 2003 01:15:59 -0000
@@ -612,9 +612,11 @@
  */
 BOOL WINAPI ImmGetOpenStatus(HIMC hIMC)
 {
-    InputContextData *data = (InputContextData*)hIMC;
+  InputContextData *data = (InputContextData*)hIMC;
 
   FIXME("(%p): semi-stub\n", hIMC);
+
+  if (!data) return FALSE;
 
   return data->bOpen;
 }


More information about the wine-devel mailing list