list view completely mangled in WINE

Dimitrie O. Paun dpaun at rogers.com
Mon Aug 2 18:33:38 CDT 2004


On Sat, Jul 31, 2004 at 05:52:21AM +0200, Filip Navara wrote:
> Tobias Burnus wrote:
> [snip]
> 
> Can you try the attached patch please?
> 
> Changelog:
> - Don't update infoPtr->dwStyle in LISTVIEW_WindoProc. It's already
>   handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing.
>  
> -  if (infoPtr)
> -  {
> -    infoPtr->dwStyle = GetWindowLongW(hwnd, GWL_STYLE);
> -  }
> -
>    switch (uMsg)
>    {
>    case LVM_APPROXIMATEVIEWRECT:

Can you please explain why updating it is a problem? Yes, we may be
doing more work than needed, but at most it should be a no-op.
In fact, we used to call 'GetWindowLongW(hwnd, GWL_STYLE)' every
time we needed to get to the dwStyle, so updating it in there
should be OK.

BTW, I've tried to install the demo, but the installer dies on my
version of wine. Does it work for you, or did you use Windows for
the installation?

-- 
Dimi.



More information about the wine-devel mailing list