"winetest" throws an exception after the unsuccessful send operation

Saulius Krasuckas saulius2 at ar.fi.lt
Wed Aug 18 07:40:27 CDT 2004


On Wed, 18 Aug 2004, Ferenc Wagner wrote:
> > We can use the "str" instead of the "buffer".  I've tried
> > such mod and it worked fine in my case:
> 
> Yes, your patch is good.  Still I recommend something more,
> as I can't see why buffer should be dynamic at all.  Please
> check it in case I made another mistake:

Ok then.  In this case "my" part of the patch can be omitted:

> @@ -209,17 +208,15 @@
>      if (ret) {
>          buffer[total] = 0;
>          str = strstr (buffer, "\r\n\r\n");
> -        if (str) buffer = str + 4;
> +        str = str ? str+4 : buffer;
>          report (R_ERROR, "Can't submit logfile '%s'. "
> -                "Server response: %s", name, buffer);
> +                "Server response: %s", name, str);
>      }

..as "buffer" doesn't need to be preserved anymore. =)




More information about the wine-devel mailing list