questionable code
Robert Shearman
rob at codeweavers.com
Sat Dec 11 10:32:43 CST 2004
Eric Pouech wrote:
> *** dlls/ole32/hglobalstream.c line 602
> the test "if (newPosition.QuadPart < 0)" is always false as QuadPart
> is unsigned
>
Before the call to RtlLargeIntegerAdd we need to add a line with:
if ((dlibMove.QuadPart < 0) && (newMove < -dlibMove.QuadPart)) return
STG_E_INVALIDFUNCTION;
And remove the offending < 0 line.
You can submit a patch for me, or wait until Monday and I'll submit one.
Rob
More information about the wine-devel
mailing list