Includes [4] shlwapi

[Jon Griffiths]

Hi,

> Well, it's more work for the poor slob who has to review, test, and
> commit the resulting patches <g>

gulp, I guess thats me, <sniff> ;-)

>  (not to mention for people who
> maintain local changes and need to fix merge conflicts after each
> commit).

I wondered about that; the good news is that all the diffs are at the
very top of the source files, so any existing patches should continue
to apply, albeit offset by a line or two. The only real conflict
possible is if local changes are messing with the includes (which of
course, does/will happen). But of course, everyones future rebuild
times after a cvs update will go down as a result, so the net result
should be a win :-)

Anyway, I've updated my script with the suggestions given and include
it below if anyones interested. I will be posting the (much reduced,
but still significant) patch very shortly to wine-patches.

As mentioned in the script blurb, this only removes headers that
don't cause extra warnings or build errors, that actually reduce
dependencies, and it won't remove a header that provides a prototype
for the function(s) implemented in a source file.

As the private includes get cleaned up I'll re-run this once in a
while to weed out any more that crop up.

Cheers,
Jon


=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

jon_p_griffiths at yahoo.com


		
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Find what you need with new enhanced search.
http://info.mail.yahoo.com/mail_250
-------------- next part --------------
A non-text attachment was scrubbed...
Name: find_useless_includes.pl
Type: application/octet-stream
Size: 8063 bytes
Desc: find_useless_includes.pl
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20041213/294d4a37/find_useless_includes.obj