wine/dlls shell32/shlfileop.c shell32/shlexec. ...

[Robert Shearman]

Christian Costa wrote:

> Hi Michael,
>
> This is typically the kind of patches that breaks everything.


It cannot break anything.

> The code you find useless, is often use in lazy allocation or error 
> handling.
> I doubt the current wine code is so bad designed even if there is some 
> cases where the test is useless.
> For example in memallocator.c, this is wrong because you can release 
> the allocator even before allocating
> the memory with the SetProperties method.


I think you are a little confused. HeapFree can be called with a NULL 
pointer. On Win9x, this causes an error to be set, but from Windows 2000 
onwards and Wine, it is allowed and is not an error.

> Looking at your other patches, there is some changes that seems 
> suspect to me (in winmm and directx).


The new code is perfectly correct, and is cleaner.

Rob