[OLE #16] Comment out an assert, as we don't yet implement IRemUnknown

Andreas Mohr andi at rhlx01.fht-esslingen.de
Tue Dec 28 10:30:42 CST 2004


Hi,

On Tue, Dec 28, 2004 at 03:37:17PM +0000, Mike Hearn wrote:
> Mike Hearn <mh at codeweavers.com>
> Comment out an assert, as we don't yet implement IRemUnknown
> 
> --- dlls/ole32/stubmanager.c  (revision 9)
> +++ dlls/ole32/stubmanager.c  (local)
> @@ -171,8 +175,10 @@ int stub_manager_unref(struct stub_manag
>          EnterCriticalSection(&m->lock);
>          if (!list_empty(&m->ifstubs))
>          {
> -            ERR("PANIC: Stub manager is being destroyed with outstanding interface stubs\n");
> -            assert( FALSE );
> +            ERR("PANIC: Stub manager %s is being destroyed with outstanding interface stubs\n", wine_dbgstr_longlong(m->oid));
> +            
> +            /* assert( FALSE ); */
> +            /* fixme: this will happen sometimes until we do proper lifecycle management via IRemUnknown */
>          }
>  
>          /* fixme: the lifecycle of table-weak marshals is not

$ find|xargs grep FIXME|wc -l
  11011
$ find|xargs grep fixme|wc -l
     83

Might be good to keep it that way...

Andreas Mohr



More information about the wine-devel mailing list