Fix compile of programs/winedbg/elf.c on NetBSD 1.6
Yorick Hardy
yh at metroweb.co.za
Sun Feb 22 23:04:08 CST 2004
Thanks for your input. It is very likely that I misunderstood, but I found
the following in /usr/include/elf.h on NetBSD 1.6
/*
* Symbol Table
*/
typedef struct {
...
Elf32_Half st_shndx; /* section index of symbol */
} Elf32_Sym;
...
/*
* Special section indexes
*/
#define SHN_UNDEF 0 /* Undefined section */
Is this consistent with what you said? If so, I can try submit
what you suggested tonight.
Kind regards,
Yorick Hardy.
> Yorick Hardy a écrit :
>> Changelog: Use SHN_UNDEF instead of STN_UNDEF when it is defined
>> and STN_UNDEF is not. Fixes compiling on NetBSD 1.6.
>>
>>
>> Kind regards,
>>
> both STN_UNDEF and SHN_UNDEF exist in ELF definition and are meant to be
> used in different cases, which your patch mixes. Hence the fix is wrong
> (even if by change STN_UNDEF and SHN_UNDEF both are defined as 0)
> So, I'd rather suggest something (at the top of the file) as
> #ifndef STN_UNDEF
> # define STN_UNDEF 0
> #endif
>
> A+
>
--------------------------------------------------------
This message was sent using MetroWEB's AirMail service.
http://www.metroweb.co.za/ - full access for only R59.
Free WebMail, Calendar, Anti-Virus, Anti-Spam, 10 emails
Phone Now! 086 11 11 440
More information about the wine-devel
mailing list