Add support for TB_GETMETRICS and TB_SETMETRICS messages

Dmitry Timoshkov dmitry at baikal.ru
Sun Mar 7 09:13:32 CST 2004


"Robert Shearman" <R.J.Shearman at warwick.ac.uk> wrote:

> > A comment for szPadding in Wine says: /* padding values around button */.
> >
> > Looks like toolbar.c has plenty of similar (and possibly
> > redundant) things:
> >
> > INT      nHeight;        /* height of the toolbar */
> > INT      nWidth;         /* width of the toolbar */
> > RECT     client_rect;
> > RECT     rcBound;        /* bounding rectangle */
> 
> Yes, on first inspection it looks as though they are redundant. I'll take a
> look at this and see if I can clean it up.
> I have a fairly large patch for the drawing code in the works which should
> make it much easier to add themeing support and looks much neater, so I'll
> get this out of the way first.
> 
> > What another field should be used for c[x|y]ButtonSpacing instead?
> 
> It looks like it. It shouldn't be too hard to add support for it. You will
> just need to change TOOLBAR_CalcToolbar to add on the extra spacing between
> the buttons.

I take it that toolbar.c code doesn't have support for button spacing yet?
In that case I'll wait for your work. Feel free to add support for it in
your patch and incorporate my work in it.

-- 
Dmitry.




More information about the wine-devel mailing list